lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed
    Date
    When a call to request_irq() failed pm8001_setup_msix()
    still returns the success. This udate fixes the described
    misbehaviour.

    Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
    Cc: xjtuwjp@gmail.com
    Cc: lindar_liu@usish.com
    Cc: linux-scsi@vger.kernel.org
    Cc: linux-pci@vger.kernel.org
    Acked-by: Jack Wang <xjtuwjp@gmail.com>
    ---
    drivers/scsi/pm8001/pm8001_init.c | 5 +++--
    1 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
    index e90c89f..e837ece 100644
    --- a/drivers/scsi/pm8001/pm8001_init.c
    +++ b/drivers/scsi/pm8001/pm8001_init.c
    @@ -744,9 +744,10 @@ static u32 pm8001_setup_msix(struct pm8001_hba_info *pm8001_ha)
    pm8001_ha->irq_vector[i].irq_id = i;
    pm8001_ha->irq_vector[i].drv_inst = pm8001_ha;

    - if (request_irq(pm8001_ha->msix_entries[i].vector,
    + rc = request_irq(pm8001_ha->msix_entries[i].vector,
    pm8001_interrupt_handler_msix, flag,
    - intr_drvname[i], &(pm8001_ha->irq_vector[i]))) {
    + intr_drvname[i], &(pm8001_ha->irq_vector[i]));
    + if (rc) {
    for (j = 0; j < i; j++)
    free_irq(
    pm8001_ha->msix_entries[j].vector,
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2014-07-16 21:01    [W:4.237 / U:0.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site