Messages in this thread | | | Date | Wed, 16 Jul 2014 05:47:29 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 2/3] rcu: Remove stale comment in tree.c |
| |
On Tue, Jul 15, 2014 at 06:57:59PM -0400, Pranith Kumar wrote: > > On 07/15/2014 06:53 PM, josh@joshtriplett.org wrote: > > On Tue, Jul 15, 2014 at 06:31:48PM -0400, Pranith Kumar wrote: > >> This commit removes a stale comment in rcu/tree.c. > >> FYI, an updated comment exists a few lines below this. > >> > >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> > > In general, when removing a stale comment, I'd suggest explaining why > > the comment is stale. Was code removed without removing the > > corresponding comment, or was code changed such that the comment no > > longer applies, or...? > > I guess it was left out when code was moved around previously. And I did mention that an updated comment is there a few lines below. > > For reference this is the new comment which is below the old comment, they mean the same :) > > /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
Indeed that is the case.
Please update the commit log with this explanation and resend.
Thanx, Paul
| |