Messages in this thread | | | Date | Wed, 16 Jul 2014 10:44:46 +0800 | From | Jason Wang <> | Subject | Re: [PATCH net-next] virtio-net: rx busy polling support |
| |
On 07/15/2014 06:21 PM, Eric Dumazet wrote: > On Tue, 2014-07-15 at 17:41 +0800, Jason Wang wrote: >> Add basic support for rx busy polling. >> >> 1 byte netperf tcp_rr on mlx4 shows 116% improvement: the transaction >> rate was increased from 9151.94 to 19787.37. > This is a misleading changelog. > > You forgot to describe how you allowed busy polling, as it is not > 'automatic' > > If not, this patch adds two spinlock/unlock pairs in fast path.
Ok. > Also, it looks like you could split this in smaller patches. > > virtnet_napi_disable_all() & virtnet_napi_enable_all() could be added in > a separate patch for example.
Sure, will split this patch into smaller ones in V2.
Thanks
| |