Messages in this thread | | | Date | Tue, 15 Jul 2014 16:32:27 +0900 | Subject | Re: [PATCH 7/8] staging: dgap: introduce dgap_cleanup_nodes() | From | DaeSeok Youn <> |
| |
2014-07-15 15:41 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>: > On Tue, Jul 15, 2014 at 12:04:02PM +0900, Daeseok Youn wrote: >> When a configration file is parsed with dgap_parsefile(), >> makes nodes for saving configrations for board. >> >> Making a node will allocate node memory and strings for saving >> configrations with kstrdup(). >> >> So these are freed when dgap is unloaded or failed to initialize. >> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> >> --- >> It MUST be needed to prevent memory leaks but >> I'm not sure that I fix properly. >> >> Please review. > > This thread doesn't have Mark on the CC list and he's the only person > who can actually test it properly. Resend it and CC Mark > Hounschell <markh@compro.net>.
Really? I'd added Mark to CC list. hmm.. In your reply doesn't have Mark. I was checking sent-box, he is in the CC list.
OK. I will try to send this again after fixing 6/7 and 8/8. Thanks.
regards, Daeseok Youn > > regards, > dan carpenter >
| |