Messages in this thread | | | Date | Tue, 15 Jul 2014 10:32:34 +0100 | From | Morten Rasmussen <> | Subject | Re: [PATCH v3 09/12] Revert "sched: Put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED" |
| |
On Tue, Jul 15, 2014 at 10:27:19AM +0100, Vincent Guittot wrote: > On 11 July 2014 18:13, Morten Rasmussen <morten.rasmussen@arm.com> wrote: > > [snip] > > > > > In this example using rq->avg leads to imbalance whereas unweighted load > > would not. Correct me if I missed anything. > > You just miss to take into account how the imbalance is computed
I don't think so. I'm aware that the imbalance is calculated based on the runnable_load_avg of the cpus. But if you pick the wrong cpus to compare to begin with, it doesn't matter.
Morten
| |