Messages in this thread | | | Date | Tue, 15 Jul 2014 16:53:34 -0700 | From | Greg KH <> | Subject | Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs |
| |
On Tue, Jul 15, 2014 at 10:05:54PM +0200, Peter Senna Tschudin wrote: > On Tue, Jul 15, 2014 at 5:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote: > >> This patch removes uneeded typedefs reported by chackpatch and removes > >> one enum. The removed enum from card.h: > >> > >> typedef enum _CARD_PHY_TYPE { > >> PHY_TYPE_AUTO = 0, > >> PHY_TYPE_11B, > >> PHY_TYPE_11G, > >> PHY_TYPE_11A > >> } CARD_PHY_TYPE, *PCARD_PHY_TYPE; > > > > Why did you remove this? > Unlike the other two enums this patch change, this one is not in use. > As checkpatch complained about the typedef and it is not currently in > use, I removed it.
Then say that, we want to know _why_ you do something, not _what_ you do, as it's obvious from the code as to _what_ happens.
thanks,
greg k-h
| |