Messages in this thread | | | From | "Gabbay, Oded" <> | Subject | Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE | Date | Mon, 14 Jul 2014 07:33:47 +0000 |
| |
On Sat, 2014-07-12 at 07:42 +1000, Dave Airlie wrote: > > +/* The 64-bit ABI is the authoritative version. */ > > +#pragma pack(push, 8) > > + > > Don't do this, pad and align things explicitly in structs. > > > +struct kfd_ioctl_create_queue_args { > > + uint64_t ring_base_address; /* to KFD */ > > + uint32_t ring_size; /* to KFD */ > > + uint32_t gpu_id; /* to KFD */ > > + uint32_t queue_type; /* to KFD */ > > + uint32_t queue_percentage; /* to KFD */ > > + uint32_t queue_priority; /* to KFD */ > > + uint64_t write_pointer_address; /* to KFD */ > > + uint64_t read_pointer_address; /* to KFD */ > > + > > + uint64_t doorbell_address; /* from KFD */ > > + uint32_t queue_id; /* from KFD */ > > +}; > > + > > maybe put all the uint64_t at the start, or add explicit padding. > > Dave. Thanks, will be fixed. Oded | |