Messages in this thread | | | Date | Mon, 14 Jul 2014 15:32:35 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH] can: flexcan: add vf61x support for flexcan |
| |
On Mon, Jul 14, 2014 at 09:06:33AM +0200, Stefan Agner wrote: > Am 2014-07-14 08:04, schrieb Shawn Guo: > > On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote: > >> >> @@ -362,7 +374,7 @@ > >> >> > >> >> esdhc1: esdhc@400b2000 { > >> >> compatible = "fsl,imx53-esdhc"; > >> >> - reg = <0x400b2000 0x4000>; > >> >> + reg = <0x400b2000 0x1000>; > >> > > >> > What's that doing here? :) > >> > >> That's an error I just stumbled upon. > > > > I do not see why it's an error. From Table 2-1. System Memory Map in > > i.MX53 RM, the size of ESDHC1 is 16K. > > > > Shawn > > Hi Shawn, > > In the Vybrid RM memory map, 0x400B4000 is allocated to USB. 0x400B3000 > is empty, whereas for other peripherals (e.g. FlexCAN) which use > multiple 0x1000 blocks, they are all explicitly stated. That is why I > assumed 0x1000 is correct.
Ah, sorry. I thought you're on i.MX53. You're right about Vybrid, and it should be 0x1000.
> > But then, the memory map within the SDHC peripheral has some registers > also located in 0x400B3000.
Really? Which one?
Shawn
> Hence I think 0x2000 is correct. Will send > an updated and separated patch.
| |