Messages in this thread | | | Date | Sat, 12 Jul 2014 07:42:45 +1000 | Subject | Re: [PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE | From | Dave Airlie <> |
| |
> +/* The 64-bit ABI is the authoritative version. */ > +#pragma pack(push, 8) > +
Don't do this, pad and align things explicitly in structs.
> +struct kfd_ioctl_create_queue_args { > + uint64_t ring_base_address; /* to KFD */ > + uint32_t ring_size; /* to KFD */ > + uint32_t gpu_id; /* to KFD */ > + uint32_t queue_type; /* to KFD */ > + uint32_t queue_percentage; /* to KFD */ > + uint32_t queue_priority; /* to KFD */ > + uint64_t write_pointer_address; /* to KFD */ > + uint64_t read_pointer_address; /* to KFD */ > + > + uint64_t doorbell_address; /* from KFD */ > + uint32_t queue_id; /* from KFD */ > +}; > +
maybe put all the uint64_t at the start, or add explicit padding.
Dave.
| |