Messages in this thread | | | Subject | Re: [PATCH peterz-queue:locking/core 1/2] locking/rwsem: Fix building with opt spinning and new osq_lock header | From | Jason Low <> | Date | Fri, 11 Jul 2014 14:13:35 -0700 |
| |
On Fri, 2014-07-11 at 14:00 -0700, Davidlohr Bueso wrote: > Commit 'rwsem: Reduce the size of struct rw_semaphore' broke all > DECLARE_RWSEM users, ie: > > init/init_task.c:14:44: error: ‘OSQ_UNLOCKED_VA’ undeclared here (not in a function) > > Signed-off-by: Davidlohr Bueso <davidlohr@hp.com> > --- > include/linux/rwsem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h > index 0eff99c..5d40884 100644 > --- a/include/linux/rwsem.h > +++ b/include/linux/rwsem.h > @@ -64,7 +64,7 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem) > #endif > > #if defined(CONFIG_SMP) && !defined(CONFIG_RWSEM_GENERIC_SPINLOCK) > -#define __RWSEM_OPT_INIT(lockname) , .owner = NULL, .osq = { ATOMIC_INIT(OQS_UNLOCKED_VAL) } > +#define __RWSEM_OPT_INIT(lockname) , .owner = NULL, .osq = { ATOMIC_INIT(OSQ_UNLOCKED_VAL) }
Hi David, I'll be sending out a v2 patchset which address Steven's feedback (which includes using a macro instead of directly initializing the osq field).
Thanks!
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |