Messages in this thread | | | Date | Fri, 11 Jul 2014 11:07:00 +0200 | Subject | Re: [PATCH v3 3/5] phy: miphy365x: Provide support for the MiPHY356x Generic PHY | From | Gabriel Fernandez <> |
| |
Hi Lee
One suggestion
On 9 July 2014 13:41, Lee Jones <lee.jones@linaro.org> wrote: > The MiPHY365x is a Generic PHY which can serve various SATA or PCIe > devices. It has 2 ports which it can use for either; both SATA, both > PCIe or one of each in any configuration. > > Acked-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/phy/Kconfig | 10 + > drivers/phy/Makefile | 1 + > drivers/phy/phy-miphy365x.c | 616 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 627 insertions(+) > create mode 100644 drivers/phy/phy-miphy365x.c >
[...]
> diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c > new file mode 100644 > index 0000000..65ecd04 > --- /dev/null > +++ b/drivers/phy/phy-miphy365x.c > @@ -0,0 +1,616 @@
[...]
> + > +struct miphy365x_phy { > + struct phy *phy; > + void __iomem *base; > + void __iomem *sata; > + void __iomem *pcie; > + u8 type; > + u8 port;
if we add: struct miphy365x_dev *phydev;
it's could simplified call of procedures below ?
for e.g. static int miphy365x_set_path(struct miphy365x_phy *miphy_phy, struct miphy365x_dev *miphy_dev)
into
static int miphy365x_set_path(struct miphy365x_phy *miphy_phy) { struct miphy365x_dev *miphy_dev=miphy_phy->phydev;
[...]
Best regards Gabriel
| |