lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] sched: Rewrite per entity runnable load average tracking
On Thu, Jul 10, 2014 at 10:01:42AM -0700, bsegall@google.com wrote:
> > The problem with that is that last_update_time is measured in
> > clock_task, and you cannot transfer these values between CPUs.
> > clock_task can drift unbounded between CPUs.
>
> Yes, but we don't need to - we just use the remote last_update_time to
> do a final update on p->se.avg, and then subtract that from cfs_rq->avg
> with atomics (and then set p->se.avg.last_update_time to 0 as now). This
> throws away any time since last_update_time, but that's no worse than
> current, which throws away any time since decay_counter, and they're
> both called from enqueue/dequeue/tick/update_blocked_averages.

Yes, old CPU clock_task will not go to new CPU, we set last_update_time to 0,
and on new CPU, when enqueued, it will start with new clock. Just throw some time
way as Ben said.

Actually, this throwing away is not bad after a second thought, because it results in
less decaying the wakee load, which effectively add some load/weight to the wakee,
sounds good.

Thanks,
Yuyang


\
 
 \ /
  Last update: 2014-07-11 07:05    [W:0.132 / U:1.716 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site