Messages in this thread | | | Date | Thu, 10 Jul 2014 09:38:00 +0200 | Subject | Re: [PATCH] usb: usb5303: make use of uninitialized err variable | From | Geert Uytterhoeven <> |
| |
Hi Greg,
On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote: >> The variable err is not initialized here, this patch uses it >> to store an eventual error value from devm_clk_get(). >> >> Signed-off-by: Emil Goode <emilgoode@gmail.com> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> >> --- >> drivers/usb/misc/usb3503.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-)
> This patch fails to apply to my tree :(
You've already applied commit ec5734c41bee2ee7c938a8f34853d31cada7e67a Author: Tushar Behera <tushar.b@samsung.com> Date: Tue Jun 17 16:38:50 2014 +0530
usb: misc: usb3503: Update error code in print message
'err' is uninitialized, rather print the error code directly.
which fixes it slightly different.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |