lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: r8821ae: avoid leaking format string
On Thu, Jul 10, 2014 at 01:16:11PM -0700, Kees Cook wrote:
> This make sure a format string cannot leak into the work queue name nor
> the printk buffer.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> This is the third time this set of macros has entered the kernel:
>
> drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h
> drivers/staging/rtl8821ae/btcoexist/halbtcoutsrc.h
>
> Can we extract these macros to some common place and keep them from returning?

I wish. These are all from the same company. Each new version of their
hardware consists of a whole dump of a wireless stack. People are
working on addressing this issue, by writing "real" drivers for the
hardware, and working with the company to not keep doing this. But odds
are, I'll get a new driver for the next chip from them that does the
same thing :(

thanks for the patch, I'll queue it up.

greg k-h


\
 
 \ /
  Last update: 2014-07-10 23:21    [W:0.037 / U:2.248 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site