lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tile: Add underscores to defintions
    On 7/5/2014 12:32 AM, Nicholas Krause wrote:
    > In file drv_xgbe_impl.h I fixed the definitions for Size Small,
    > Size Large, Size Jumbo to have underscores before and after to
    > follow kernel coding style for internel defentions.
    >
    > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
    > ---
    > arch/tile/include/hv/drv_xgbe_impl.h | 15 +++------------

    I don't think there is a kernel coding style for internal definitions.
    It's true that double-underscores mean "more raw" in many places, like
    for things like set_bit() vs __set_bit(), but that's not really
    applicable here. These files are not exported outside of the kernel
    in any case so we don't need any special treatment for them to mark them
    as "internal definitions".

    The comment in any case certainly is silly. It dates back to Jan 2007
    in our internal version control system. The tilepro hv headers in
    question are largely frozen at this point in our internal "upstream"
    repository where we take these headers from, so it doesn't seem worth
    the effort to try to improve the comments there, nor worth adding skew
    between those headers and the community headers.

    --
    Chris Metcalf, Tilera Corp.
    http://www.tilera.com



    \
     
     \ /
      Last update: 2014-07-10 21:01    [W:2.439 / U:3.144 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site