lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/6] x86-mce: Clear CMCI enable on all claimed CMCI banks before reboot.
From
On Thu, Jul 10, 2014 at 9:24 AM, Borislav Petkov <bp@alien8.de> wrote:
> We don't need all that atomicity special fun if we register the reboot
> notifier on the BSP, say from mcheck_init() which is done even pre-SMP.
>
> If that's too early, we can add an initcall or whatever...

OK, will see if I can find a better place for it.

> Also, since this is kexec-only, this all should be nicely enabled only
> on KEXEC kernels. Please use the ifdeffery sparingly :-)
>
> I'm saying that because I'm assuming BIOS will clear those MSRs upon
> warm reset. If it doesn't, then we have a bigger problem.

Even on kexec-enabled kernels, we might be doing a regular BIOS boot.
Is there any way to detect that we're doing a kexec boot and only
clearing the MSRs in that case?

Havard


\
 
 \ /
  Last update: 2014-07-10 20:41    [W:0.077 / U:22.656 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site