lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] platform/chrome: pstore: fix dmi table to match all chrome systems
From
On Thu, Jul 10, 2014 at 10:20 AM, Olof Johansson <olof@lixom.net> wrote:
> Turns out that DMI_SYSTEM_VENDOR is actually the native vendor of each
> Chromebook/box. I tested the original patch on a Pixel that -- surprise,
> has Google as vendor. *facepalm*.
>
> The only other data I can think of to probe on is Google_* in the version
> string. Checking with our firmware team, all systems should have this
> and nothing else than Chrome hardware should have the coreboot + Google_*
> combination to date.
>
> So, we'll switch to this. For future platforms we are going to move to
> using an ACPI device to configure this instead of a DMI table (yay!),
> so longer-term that will sort itself out.
>
> Signed-off-by: Olof Johansson <olof@lixom.net>

Reviewed-by: Benson Leung <bleung@chromium.org>


--
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org


\
 
 \ /
  Last update: 2014-07-10 20:21    [W:0.033 / U:19.448 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site