[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3] i2c: busses: i2c-pxa.c: Fix for possible null pointer dereferenc

> Ok then, Wolfram!
> Keep only:
> ereqirq:
> clk_disable_unprepare(i2c->clk);
> And let everyone else just return?

I haven't looked at the details, but when you simply can return, do it.

> It is rather pointless to add something in a patch, to remove it in the next.

Yup, just say in the patch description that it fixes this bug.

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-07-10 14:41    [W:0.060 / U:0.132 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site