lkml.org 
[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v7 10/33] net: dummy - set name assign type
On Thu, Jul 10, 2014 at 12:26 PM, David Herrmann <dh.herrmann@gmail.com> wrote:
> Hi
>
>>> The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same
>>> from a kernel point of view.
>>
>> You mean to collapse the two, and just label renamed interfaces
>> NET_NAME_USER instead?
>
> I have no real objections to merging NAME_USER and NAME_RENAMED. Both
> values imply that there is a user-space authority that applied some
> kind of rules to the naming-scheme. Therefore, anyone reacting to
> those names should better treat them equally and fix the
> naming-authority instead of overwriting it.

I basically agree. There is no strong reason to keep these separate,
so I would not object strongly to merging them.

However, I also don't see any harm in keeping the distinction. If
userspace wants to treat them the same, it easily can. However, if a
usecase appears in the future where the distinction is important, we
can no longer split them apart again. For that reason, I'd slightly
prefer keeping them separate, unless there is a compelling reason not
to...

Cheers,

Tom


\
 
 \ /
  Last update: 2014-07-10 13:21    [W:0.322 / U:19.888 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site