[lkml]   [2014]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRE: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller
HI Greet,

>-----Original Message-----
>From: Harini Katakam []
>Sent: Thursday, July 10, 2014 3:01 PM
>To: Geert Uytterhoeven
>Cc: Mark Brown; Grant Likely; Rob Herring; Pawel Moll; Mark Rutland; Ian
>Campbell; Kumar Gala; linux-spi;;
>;; David Woodhouse;
>Brian Norris; Marek Vašut; Artem Bityutskiy; Geert Uytterhoeven; Sascha
>Hauer; Jingoo Han; Sourav Poddar; Michal Simek; Punnaiah Choudary Kalluri
>Subject: Re: [RFC PATCH 1/2] spi: Add support for Zynq QSPI controller
>Hi Geert,
>On Thu, Jul 10, 2014 at 2:48 PM, Geert Uytterhoeven
><> wrote:
>> Hi Harini,
>> On Thu, Jul 10, 2014 at 10:50 AM, Harini Katakam <>
>>> + master->flags = SPI_MASTER_QUAD_MODE;
>> SPI_MASTER_QUAD_MODE is not one of the SPI_MASTER_* defines
>> in include/linux/spi/spi.h?
>I'm sorry about that. That flag is unused - will remove this statement.
>>> + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_RX_DUAL |
>> Your driver advertises Dual/Quad SPI Transfer capabilities, but it doesn't
>> check spi_transfer.[tr]x_nbits? How can it determine when to enable
>Here the driver is just giving information that the controller support it.
>The MTD layer enables dual/quad based on what the flash supports; quad
>being the first priority
>I understand that the spi core reads rx, tx-bus-width property and
>master support flags and
>performs the necessary checks.

Just to add, the zynq qspi controller will automatically select the IO lines based
On the flash command.


 \ /
  Last update: 2014-07-10 12:21    [W:0.128 / U:3.888 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site