Messages in this thread | | | From | Jes Sorensen <> | Subject | Re: [PATCH 1/1] staging: rtl8723au: Remove unnecessary null test before kfree | Date | Tue, 01 Jul 2014 09:01:14 +0200 |
| |
Fabian Frederick <fabf@skynet.be> writes: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required > > Cc: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Jes Sorensen <Jes.Sorensen@redhat.com> > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Fabian Frederick <fabf@skynet.be> > --- > drivers/staging/rtl8723au/core/rtw_cmd.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c b/drivers/staging/rtl8723au/core/rtw_cmd.c > index 1696cb8..6af2b4a 100644 > --- a/drivers/staging/rtl8723au/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723au/core/rtw_cmd.c > @@ -516,9 +516,7 @@ int rtw_joinbss_cmd23a(struct rtw_adapter *padapter, > > psecnetwork = &psecuritypriv->sec_bss; > if (!psecnetwork) { > - if (pcmd) > - kfree(pcmd); > - > + kfree(pcmd); > res = _FAIL; > > RT_TRACE(_module_rtl871x_cmd_c_, _drv_err_,
Thanks, I applied this one to the rtl8723au tree.
Jes
| |