Messages in this thread | | | Date | Tue, 1 Jul 2014 18:08:53 +0100 | From | Catalin Marinas <> | Subject | Re: [RFC PATCH 0/6] kernel: Add support for restart notifier call chain |
| |
On Tue, Jul 01, 2014 at 02:45:24PM +0100, Guenter Roeck wrote: > On 07/01/2014 04:24 AM, Catalin Marinas wrote: > > On Mon, Jun 30, 2014 at 09:28:51PM +0100, Guenter Roeck wrote: > >> What is restart-poweroff supposed to do in the first place, and why > >> doesn't it call machine_restart() ? If it is what I think it is, ie > >> a fallback for pm_power_off, it could be made generic and does not > >> really have to depend on ARM. > > > > I think this one pretends to do a power-off via restart. It could call > > machine_restart() but this only passes the default reboot_mode to > > arm_pm_restart(). > > Unless one sets reboot_mode first. See my proposed patch in > https://lkml.org/lkml/2014/6/30/792.
It looks fine to me.
-- Catalin
| |