Messages in this thread | | | Date | Tue, 1 Jul 2014 11:35:56 -0700 | Subject | Re: [PATCH] PCI: Do not touch siblings in pci_assign_unassigned_bridge_resources | From | Yinghai Lu <> |
| |
On Mon, Jun 30, 2014 at 3:47 PM, Bjorn Helgaas <bhelgaas@google.com> wrote: >> Should not be dangerous, just second try. > > I still don't understand this. Why do we set "res->flags = 0"? That > clears out the resource type. Where do we figure out the type of "res" > again?
pci_bridge_check_ranges()
>> Subject: [PATCH] pci: Add back missing MEM_64 check for hotplug path >> >> We miss that in >> | commit 5b28541552ef5eeffc41d6936105f38c2508e566 >> | PCI: Restrict 64-bit prefetchable bridge windows to 64-bit resources >> for pci hotplug path. > > This changelog is useless. I don't have time to spend a few hours > figuring out why we want this change.
We have MEM_64 in type_mask from pci_assign_unassigned_root_bus_resources(). And I missed the same change for hotplug path.
That is for exact type checking.
Thanks
Yinghai
| |