| From | Ohad Ben-Cohen <> | Date | Tue, 1 Jul 2014 15:48:59 +0300 | Subject | Re: [PATCHv5 05/15] hwspinlock/omap: add support for dt nodes |
| |
Hi Suman,
On Thu, May 1, 2014 at 3:34 AM, Suman Anna <s-anna@ti.com> wrote: > static int omap_hwspinlock_probe(struct platform_device *pdev) > { > - struct hwspinlock_pdata *pdata = pdev->dev.platform_data; > + struct device_node *node = pdev->dev.of_node; > struct hwspinlock_device *bank; > struct hwspinlock *hwlock; > struct resource *res; > void __iomem *io_base; > int num_locks, i, ret; > + int base_id = 0;
We shouldn't implicitly assume base_id is zero: let's explicitly protect against potential subsequent invocations of omap_hwspinlock_probe.
Thanks, Ohad.
|