Messages in this thread | | | Date | Tue, 1 Jul 2014 13:11:42 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: core: Still free GPIOs using gpio_free() |
| |
On Tue, Jul 01, 2014 at 01:06:22PM +0100, Russell King - ARM Linux wrote: > On Tue, Jul 01, 2014 at 12:55:26PM +0100, Mark Brown wrote:
> > Even though we mostly use GPIO descriptors internally we still use > > gpio_request_one() to request so we need to pair that with gpio_free() to > > release the GPIO.
> This doesn't explain the reason... I see the current GPIO code doing this:
> void gpio_free(unsigned gpio) > { > gpiod_free(gpio_to_desc(gpio)); > } > EXPORT_SYMBOL_GPL(gpio_free);
Huh, good point (though it still seems a bit neater to match up the request and release functions I guess). Linus? [unhandled content-type:application/pgp-signature] | |