Messages in this thread Patch in this message | | | Subject | Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup | From | Joe Perches <> | Date | Mon, 09 Jun 2014 14:22:42 -0700 |
| |
On Tue, 2014-06-10 at 00:01 +0300, Stratos Karafotis wrote: > Remove unnecessary braces.
[]
> @@ -204,20 +203,16 @@ static inline void intel_pstate_busy_pid_reset(struct cpudata *cpu)
> static inline void intel_pstate_reset_all_pid(void) > { > unsigned int cpu; > - for_each_online_cpu(cpu) { > + > + for_each_online_cpu(cpu) > if (all_cpu_data[cpu]) > intel_pstate_busy_pid_reset(all_cpu_data[cpu]); > - }
It's pretty traditional to keep the braces here as it generally makes it clearer for the reader.
for (...) { if (foo) bar(); }
is generally used over
for (...) if (foo) bar();
Just like using
if (foo) { /* commment */ bar(); }
> @@ -748,15 +744,14 @@ static int intel_pstate_init_cpu(unsigned int cpunum) [] > - pr_info("Intel pstate controlling: cpu %d\n", cpunum); > + pr_info("Intel pstate controlling: CPU %d\n", cpunum);
cpu is very slightly preferred lower case.
$ git grep -E -i '^[^"]*"[^"]*\bcpu\b'|grep -w -i -o cpu | sort |uniq -c | sort -rn 2705 cpu 2084 CPU 17 Cpu
| |