Messages in this thread | | | Date | Mon, 09 Jun 2014 10:19:48 -0600 | From | Jens Axboe <> | Subject | Re: [PATCH] blk-mq: add timer in blk_mq_start_request |
| |
On 06/09/2014 10:16 AM, Ming Lei wrote: > This way will become consistent with non-mq case, also > avoid to update rq->deadline twice for mq. > > The comment said: "We do this early, to ensure we are on > the right CPU.", but no percpu stuff is used in blk_add_timer(), > so it isn't necessary. Even when inserting from plug list, there > is no such guarantee at all.
Thanks, this is a good cleanup. That particular comment predates the strict mappings of the queues, so it doesn't apply anymore anyway.
-- Jens Axboe
| |