Messages in this thread | | | Date | Mon, 9 Jun 2014 13:57:16 +0200 | Subject | Re: [PATCH V5 REPOST] mfd: add support for ams AS3722 PMIC | From | Linus Walleij <> |
| |
On Fri, Jun 6, 2014 at 5:28 PM, Lee Jones <lee.jones@linaro.org> wrote:
>> + as3722->en_intern_int_pullup = of_property_read_bool(np, >> + "ams,enable-internal-int-pullup"); >> + as3722->en_intern_i2c_pullup = of_property_read_bool(np, >> + "ams,enable-internal-i2c-pullup"); > > These are still not documented. Can you please do so?
...and these look an awful lot like some pin config shoehorned silently into the MFD subsystem.
There *are* cases where a complete pin control driver for some IP is overkill though, I'm worried if this is some generic disease with this driver :-/
Yours, Linus Walleij
| |