Messages in this thread | | | Date | Mon, 09 Jun 2014 13:04:22 +0400 | From | Pavel Vasilyev <> | Subject | Re: [RFC PATCH] rt/aio: fix rcu garbage collection might_sleep() splat |
| |
09.06.2014 10:22, Mike Galbraith пишет: > On Mon, 2014-06-09 at 05:17 +0200, Mike Galbraith wrote: >> On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote: >>> Hi, rt-people
> @@ -522,7 +524,9 @@ static void free_ioctx_users(struct perc > struct kioctx *ctx = container_of(ref, struct kioctx, users); > struct kiocb *req; > > + preempt_enable_rt(); > spin_lock_irq(&ctx->ctx_lock); > + local_irq_disable_rt(); > > while (!list_empty(&ctx->active_reqs)) { > req = list_first_entry(&ctx->active_reqs, > @@ -536,6 +540,8 @@ static void free_ioctx_users(struct perc > > percpu_ref_kill(&ctx->reqs); > percpu_ref_put(&ctx->reqs); > + preempt_disable_rt(); > + local_irq_enable_rt();
I think, enable_/disable_ must be as mirror reflections
preempt_enable_rt(); local_irq_disable_rt();
do_something();
local_irq_enable_rt(); preempt_disable_rt();
--
Pavel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |