Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Sat, 07 Jun 2014 02:26:28 +0100 | Subject | [PATCH 3.2 06/92] tracepoint: Do not waste memory on mods with no tracepoints |
| |
3.2.60-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
commit 7dec935a3aa04412cba2cebe1524ae0d34a30c24 upstream.
No reason to allocate tp_module structures for modules that have no tracepoints. This just wastes memory.
Fixes: b75ef8b44b1c "Tracepoint: Dissociate from module mutex" Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- kernel/tracepoint.c | 6 ++++++ 1 file changed, 6 insertions(+)
--- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -638,6 +638,9 @@ static int tracepoint_module_coming(stru struct tp_module *tp_mod, *iter; int ret = 0; + if (!mod->num_tracepoints) + return 0; + /* * We skip modules that taint the kernel, especially those with different * module headers (for forced load), to make sure we don't cause a crash. @@ -681,6 +684,9 @@ static int tracepoint_module_going(struc { struct tp_module *pos; + if (!mod->num_tracepoints) + return 0; + mutex_lock(&tracepoints_mutex); tracepoint_update_probe_range(mod->tracepoints_ptrs, mod->tracepoints_ptrs + mod->num_tracepoints);
| |