lkml.org 
[lkml]   [2014]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/9] usb: phy: add the Berlin USB PHY driver
    From
    Hi,

    On Fri, Jun 6, 2014 at 12:41 PM, Antoine Ténart
    <antoine.tenart@free-electrons.com> wrote:
    > Hi,
    >
    > On Fri, Jun 06, 2014 at 12:09:06PM +0530, Vivek Gautam wrote:
    >> On Thu, Jun 5, 2014 at 9:18 PM, Antoine Ténart
    >> <antoine.tenart@free-electrons.com> wrote:
    >> > Add the driver driving the Marvell Berlin USB PHY. This allows to
    >> > initialize the PHY and to use it from the USB driver later.
    >>
    >> Just out of curiosity, going forward we would like to have phy drivers based on
    >> generic phy framework (drivers/phy).
    >> Any particular reason that we are still adding phy drivers in usb-phy layer ?
    >>
    >> Looking at it, seems like it can very well be written based on phy framework.
    >
    > This USB controller are ChipIdea compatible, and the ChipIdea common
    > functions use the usb_phy framework. That's why this PHY driver is
    > there.

    Ok, i see that now. In that case shouldn't we be moving even the chipidea
    drivers to use the generic phy functions to get the phy and init/exit it.

    I think Felipe and Kishon can comment on this better, and tell how
    things should be. :-)

    [snip]


    --
    Best Regards
    Vivek Gautam
    Samsung R&D Institute, Bangalore
    India
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-06-06 13:41    [W:2.859 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site