lkml.org 
[lkml]   [2014]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v2] ARM: fix debug prints relevant to PCI devices
oops... I missed it somehow. I'll post a new patch.

> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Friday, June 06, 2014 9:53 AM
> To: Vidya Sagar
> Cc: linux@arm.linux.org.uk; bhelgaas@google.com;
> wangyijing@huawei.com; thierry.reding@gmail.com;
> jason@lakedaemon.net; will.deacon@arm.com; Stephen Warren; Krishna
> Thota; sagar.tv@gmail.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2] ARM: fix debug prints relevant to PCI devices
>
> On Fri, 2014-06-06 at 00:17 +0530, Vidya Sagar wrote:
> > * replaced printk with pr_info
> []
> > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> []
> > @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> >
> > /*
> > * Report what we did for this bus
> > + * (only if the bus doesn't have even one PCIe device)
> > */
> > - printk(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > - bus->number, (features & PCI_COMMAND_FAST_BACK) ?
> "en" : "dis");
> > + if (!has_pcie_dev)
> > + pr_info(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > + bus->number, (features &
> PCI_COMMAND_FAST_BACK) ? "en" : "dis");
>
> when you convert to pr_<level> you need to remove the KERN_<LEVEL>
> from the format string too.
>



\
 
 \ /
  Last update: 2014-06-06 07:41    [W:0.041 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site