lkml.org 
[lkml]   [2014]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/32] perf tools: Kbuild source related fixies
From
Date
On Tue, 2014-06-03 at 19:49 -0600, David Ahern wrote:
> On 6/3/14, 4:05 PM, Alexis Berlemont wrote:
> > From: Jiri Olsa <jolsa@redhat.com>
> > diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> > index c852c7a..b255c20 100644
> > --- a/tools/perf/builtin-lock.c
> > +++ b/tools/perf/builtin-lock.c
> > @@ -992,9 +992,11 @@ int cmd_lock(int argc, const char **argv, const char *prefix __maybe_unused)
> > usage_with_options(report_usage, report_options);
> > }
> > rc = __cmd_report(false);
> > +#ifdef CONFIG_BULTIN_SCRIPT
> > } else if (!strcmp(argv[0], "script")) {
> > /* Aliased to 'perf script' */
> > - return cmd_script(argc, argv, prefix);
> > + rc = cmd_script(argc, argv, prefix);
> > +#endif
> > } else if (!strcmp(argv[0], "info")) {
> > if (argc) {
> > argc = parse_options(argc, argv,
>
> Since you are not adding builtin-cmds.h as an included file this change
> takes away functionality.

And I guess that, because of the typo in CONFIG_BULTIN_SCRIPT, that
would also be true if builtin-cmds.h were actually included.

> Each patch should ensure that existing options
> continue to work after the change.
>
> ditto for all of the other changes to other files.


Paul Bolle



\
 
 \ /
  Last update: 2014-06-04 09:41    [W:0.111 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site