[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] KVM: x86: Fix lapic.c debug prints
Il 30/06/2014 19:39, Bandan Das ha scritto:
> Paolo Bonzini <> writes:
>> Il 30/06/2014 03:03, Nadav Amit ha scritto:
>>>>> sipi_vector = apic->sipi_vector;
>>>>> - pr_debug("vcpu %d received sipi with vector # %x\n",
>>>>> + apic_debug("vcpu %d received sipi with vector # %x\n",
>>>> Why don't we just use pr_debug all throughout ?
>>> I don't know. I just tried to make it consistent, since it really bugged
>>> me while I was debugging the local-apic.
>>> If you prefer the other way around (which does seem to be better), I can
>>> do the search-and-replace.
>> vcpu number probably could be moved inside apic_debug, at which point
>> apic_debug becomes preferrable.
> I am not sure, I think all that could be achieved with a file private
> debug define can be done with pr_debug which is generic.
> Nadav didn't introduce apic_debug to this file, so I am
> fine either way.

I am applying the patch, anything else can be done on top.


 \ /
  Last update: 2014-07-01 05:21    [W:0.053 / U:2.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site