lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX
    Date
    From: Of Richard Leitner
    > Replaces all hardcoded ttyGS strings with the PREFIX macro.
    > Due to the fact the strings are spread over different source files the
    > PREFIX definition is moved to u_serial.h

    Lots of changes like:
    > - DBG(cdev, "acm ttyGS%d completion, err %d\n",
    > - acm->port_num, req->status);
    > + DBG(cdev, "acm %s%d completion, err %d\n",
    > + PREFIX, acm->port_num, req->status);

    I'm not sure this improves the code.
    Do you see a need to ever change PREFIX?

    Even if it is a reasonable change, the name PREFIX is hopeless.
    It would have to be something like ACM_TTYNAME_PREFIX.

    David





    \
     
     \ /
      Last update: 2014-06-30 11:21    [W:3.620 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site