Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX | Date | Mon, 30 Jun 2014 08:41:18 +0000 |
| |
From: Of Richard Leitner > Replaces all hardcoded ttyGS strings with the PREFIX macro. > Due to the fact the strings are spread over different source files the > PREFIX definition is moved to u_serial.h
Lots of changes like: > - DBG(cdev, "acm ttyGS%d completion, err %d\n", > - acm->port_num, req->status); > + DBG(cdev, "acm %s%d completion, err %d\n", > + PREFIX, acm->port_num, req->status);
I'm not sure this improves the code. Do you see a need to ever change PREFIX?
Even if it is a reasonable change, the name PREFIX is hopeless. It would have to be something like ACM_TTYNAME_PREFIX.
David
| |