lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 5/5] ARM: EXYNOS: Move PMU specific definitions from common.h
Hi Pankaj,

On 25.06.2014 16:03, Pankaj Dubey wrote:
> This patch moves PMU specific definitions into a new file
> as exynos-pmu.h.
> This will help in reducing dependency of common.h in pmu.c.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/common.h | 17 -----------------
> arch/arm/mach-exynos/exynos-pmu.h | 31 +++++++++++++++++++++++++++++++
> arch/arm/mach-exynos/pm.c | 1 +
> arch/arm/mach-exynos/pmu.c | 2 +-
> 4 files changed, 33 insertions(+), 18 deletions(-)
> create mode 100644 arch/arm/mach-exynos/exynos-pmu.h
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index 296c6e1..0326ca2 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -135,23 +135,6 @@ extern struct smp_operations exynos_smp_ops;
>
> extern void exynos_cpu_die(unsigned int cpu);
>
> -/* PMU(Power Management Unit) support */
> -
> -#define PMU_TABLE_END (-1U)
> -
> -enum sys_powerdown {
> - SYS_AFTR,
> - SYS_LPA,
> - SYS_SLEEP,
> - NUM_SYS_POWERDOWN,
> -};
> -
> -struct exynos_pmu_conf {
> - unsigned int offset;
> - unsigned int val[NUM_SYS_POWERDOWN];
> -};

While at it, I'd say this struct could be moved to pmu.c, along with the
PMU_TABLE_END macro as they are both private to this file.

Best regards,
Tomasz


\
 
 \ /
  Last update: 2014-07-01 00:21    [W:0.206 / U:1.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site