lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fixes kernel panic with Null pointer in hid-appleir.c
On Fri, 20 Jun 2014, Nicholas Krause wrote:

> In for loop of function appleir_input_configured we hit
> a Null pointer after the for loop due to array_size not
> being correct needs to be changed to input_dev->keycodemax.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/hid/hid-appleir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c
> index 0e6a42d..ab0a702 100644
> --- a/drivers/hid/hid-appleir.c
> +++ b/drivers/hid/hid-appleir.c
> @@ -272,7 +272,7 @@ static void appleir_input_configured(struct hid_device *hid,
> input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_REP);
>
> memcpy(appleir->keymap, appleir_key_table, sizeof(appleir->keymap));
> - for (i = 0; i < ARRAY_SIZE(appleir_key_table); i++)
> + for (i = 0; i < ARRAY_SIZE(input_dev->keycodemax); i++)

Ugh, how is this supposed to work? input_dev->keycodemax is int, not
array. I think you actually want sizeof(appleir->keymap) there.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-06-30 17:01    [W:0.056 / U:1.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site