lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 055/181] mfd: sm501: dbg_regs attribute must be read-only
    Date
    From: Guenter Roeck <linux@roeck-us.net>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 8a8320c2e78d1b619a8fa8eb5ae946b8691de604 upstream.

    Fix:

    sm501 sm501: SM501 At b3e00000: Version 050100a0, 8 Mb, IRQ 100
    Attribute dbg_regs: write permission without 'store'
    ------------[ cut here ]------------
    WARNING: at drivers/base/core.c:620

    dbg_regs does not have a write function and must therefore be marked
    as read-only.

    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/mfd/sm501.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
    index 33f040c558d0..3799a3d64415 100644
    --- a/drivers/mfd/sm501.c
    +++ b/drivers/mfd/sm501.c
    @@ -1232,7 +1232,7 @@ static ssize_t sm501_dbg_regs(struct device *dev,
    }


    -static DEVICE_ATTR(dbg_regs, 0666, sm501_dbg_regs, NULL);
    +static DEVICE_ATTR(dbg_regs, 0444, sm501_dbg_regs, NULL);

    /* sm501_init_reg
    *
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-06-30 15:01    [W:4.116 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site