lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX
Hi,

On Mon, 30 Jun 2014 09:08:01 +0000
David Laight <David.Laight@ACULAB.COM> wrote:

> > > From: Of Richard Leitner
> > > > Replaces all hardcoded ttyGS strings with the PREFIX macro.
> > > > Due to the fact the strings are spread over different source files the
> > > > PREFIX definition is moved to u_serial.h
> > >
> > > Lots of changes like:
> > > > - DBG(cdev, "acm ttyGS%d completion, err %d\n",
> > > > - acm->port_num, req->status);
> > > > + DBG(cdev, "acm %s%d completion, err %d\n",
> > > > + PREFIX, acm->port_num, req->status);
> > >
> > > I'm not sure this improves the code.
> >
> > Maybe you're right, the readability of the code wouldn't be better afterwards,

but as I already mentioned IMHO if there is such a macro it should be used everywhere or nowhere...

>
> Indeed it will make most attempts to grep for the error message fail.

So your thought is to carve it out completely?

Are there any other opinions/ideas on that?

regards,
richard


\
 
 \ /
  Last update: 2014-06-30 13:41    [W:0.044 / U:2.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site