lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 7/9] ASoC: omap: rx51: Add some error messages
Hi!

> Add more error messages making it easier to identify problems.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> sound/soc/omap/rx51.c | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)

> + if (err) {
> + dev_err(card->dev, "Failed to add GPIOs\n");
> + return err;
> + }
>
> return err;
> }


As you'll return err, anyway, you don't need to do it inside the if()... OTOH it
does not hurt.

Acked-by: Pavel Machek <pavel@ucw.cz>

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-06-30 12:21    [W:0.217 / U:10.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site