Messages in this thread | | | From | Bandan Das <> | Subject | Re: [PATCH v2 0/4] Emulate VMXON region correctly | Date | Tue, 03 Jun 2014 16:11:10 -0400 |
| |
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 06/05/2014 08:19, Bandan Das ha scritto: >> Reference: https://bugzilla.kernel.org/show_bug.cgi?id=54521 >> >> The vmxon region is unused by nvmx, but adding these checks >> are probably harmless and may detect buggy L1 hypervisors in >> the future! > > Applied to kvm/queue, unit test patches are welcome (hint, hint!).
Jan and Paolo,
Ok, I thought a little bit about this and I am wondering what kind of tests we could have here. All the changes are pure checks and no data is returned back to the guest. The vmxon code in kvm-unit-tests already does the right thing i.e sets the revision identifier, allocs a page for the region etc
> Paolo
| |