lkml.org 
[lkml]   [2014]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] mincore: apply page table walker on do_mincore() (Re: [PATCH 00/10] mm: pagewalk: huge page cleanups and VMA passing)
On 06/02/2014 11:18 PM, Naoya Horiguchi wrote:
> + /*
> + * Huge pages are always in RAM for now, but
> + * theoretically it needs to be checked.
> + */
> + present = pte && !huge_pte_none(huge_ptep_get(pte));
> + for (; addr != end; vec++, addr += PAGE_SIZE)
> + *vec = present;
> + cond_resched();
> + walk->private += (end - addr) >> PAGE_SHIFT;

That comment is bogus, fwiw. Huge pages are demand-faulted and it's
quite possible that they are not present.


\
 
 \ /
  Last update: 2014-06-03 18:41    [W:0.081 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site