Messages in this thread | | | Date | Tue, 03 Jun 2014 08:59:45 -0700 | From | Dave Hansen <> | Subject | Re: [PATCH -mm] mincore: apply page table walker on do_mincore() (Re: [PATCH 00/10] mm: pagewalk: huge page cleanups and VMA passing) |
| |
On 06/02/2014 11:18 PM, Naoya Horiguchi wrote: > + /* > + * Huge pages are always in RAM for now, but > + * theoretically it needs to be checked. > + */ > + present = pte && !huge_pte_none(huge_ptep_get(pte)); > + for (; addr != end; vec++, addr += PAGE_SIZE) > + *vec = present; > + cond_resched(); > + walk->private += (end - addr) >> PAGE_SHIFT;
That comment is bogus, fwiw. Huge pages are demand-faulted and it's quite possible that they are not present.
| |