Messages in this thread | | | Date | Tue, 3 Jun 2014 10:00:22 -0400 | Subject | Re: [PATCH] i8042: Don't print an error message just because there's no chip | From | Benjamin Tissoires <> |
| |
On Tue, Jun 3, 2014 at 9:53 AM, Adam Jackson <ajax@redhat.com> wrote: > On Tue, 2014-02-25 at 11:06 -0500, Josh Boyer wrote: >> On Tue, Feb 25, 2014 at 10:47 AM, Adam Jackson <ajax@redhat.com> wrote: >> > From: Peter Jones <pjones@redhat.com> >> > >> > Some systems, such as EFI-based Apple systems, won't necessarily have an >> > i8042 to initialize. We shouldn't be printing an error message in this >> > case, since not detecting the chip is the correct behavior. >> > >> > v2: Downgrade to pr_notice instead of pr_err. >> > >> > Signed-off-by: Adam Jackson <ajax@redhat.com> >> >> Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org> > > Ping? This patch or something like it has been pending since 2008 [1], > would be nice to see it merged before it's old enough to start first > grade. > > [1] - https://lkml.org/lkml/2008/9/29/248 >
Hey Ajax,
regarding the input stuff, adding the maintainers always help. So adding Dmitry in CC.
BTW, the patch looks good enough: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers, Benjamin
| |