lkml.org 
[lkml]   [2014]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 041/138] tracepoint: Do not waste memory on mods with no tracepoints
    Date
    3.11.10.11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

    commit 7dec935a3aa04412cba2cebe1524ae0d34a30c24 upstream.

    No reason to allocate tp_module structures for modules that have no
    tracepoints. This just wastes memory.

    Fixes: b75ef8b44b1c "Tracepoint: Dissociate from module mutex"
    Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    kernel/tracepoint.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c
    index 031cc5655a51..63630aef3bd3 100644
    --- a/kernel/tracepoint.c
    +++ b/kernel/tracepoint.c
    @@ -641,6 +641,9 @@ static int tracepoint_module_coming(struct module *mod)
    struct tp_module *tp_mod, *iter;
    int ret = 0;

    + if (!mod->num_tracepoints)
    + return 0;
    +
    /*
    * We skip modules that taint the kernel, especially those with different
    * module headers (for forced load), to make sure we don't cause a crash.
    @@ -684,6 +687,9 @@ static int tracepoint_module_going(struct module *mod)
    {
    struct tp_module *pos;

    + if (!mod->num_tracepoints)
    + return 0;
    +
    mutex_lock(&tracepoints_mutex);
    tracepoint_update_probe_range(mod->tracepoints_ptrs,
    mod->tracepoints_ptrs + mod->num_tracepoints);
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-03 16:21    [W:3.064 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site