lkml.org 
[lkml]   [2014]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 002/138] rtlwifi: rtl8188ee: initialize packet_beacon
    Date
    3.11.10.11 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit 328e203fc35f0b4f6df1c4943f74cf553bcc04f8 upstream.

    static code analysis from cppcheck reports:

    [drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
    (error) Uninitialized variable: packet_beacon

    packet_beacon is not initialized and hence packet_beacon
    contains garbage from the stack, so set it to false.

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
    index a8871d66d56a..ea4d014a2884 100644
    --- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
    +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
    @@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw,
    u8 *psaddr;
    __le16 fc;
    u16 type, ufc;
    - bool match_bssid, packet_toself, packet_beacon, addr;
    + bool match_bssid, packet_toself, packet_beacon = false, addr;

    tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift;

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-06-03 14:21    [W:4.156 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site