Messages in this thread | | | Date | Sun, 29 Jun 2014 18:41:42 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 08/18] perf tools: Flush ordered events in case of allocation failure |
| |
On Fri, Jun 27, 2014 at 05:07:52PM -0600, David Ahern wrote: > On 6/18/14, 8:58 AM, Jiri Olsa wrote: > >+ case OEQ_FLUSH__HALF: > >+ { > >+ struct ordered_event *first, *last; > >+ struct list_head *head = &q->events; > >+ > >+ first = list_entry(head->next, struct ordered_event, list); > >+ last = q->last; > >+ > >+ if (WARN_ONCE(!last || list_empty(head), "empty queue")) > >+ return 0; > > Maybe a comment that the WARN_ONCE can only happen if perf can't allocate an > ordered event the first time through?
ok, will do..
thanks, jirka
| |