Messages in this thread Patch in this message | | | Date | Sun, 29 Jun 2014 12:48:15 +0530 | From | Himangi Saraogi <> | Subject | [PATCH] pinctrl: berlin: fix return value for dev_get_regmap |
| |
The failure value of dev_get_regmap is NULL. Hence, the return value is changed to -ENODEV.
A simplified version of the semantic match that finds this problem is as follows:
// <smpl> @@ expression e1; @@
* if (!e1) return PTR_ERR(e1);
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> --- drivers/pinctrl/berlin/berlin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c index edf5d2f..86db223 100644 --- a/drivers/pinctrl/berlin/berlin.c +++ b/drivers/pinctrl/berlin/berlin.c @@ -320,7 +320,7 @@ int berlin_pinctrl_probe(struct platform_device *pdev, regmap = dev_get_regmap(&pdev->dev, NULL); if (!regmap) - return PTR_ERR(regmap); + return -ENODEV; pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL); if (!pctrl) -- 1.9.1
| |