Messages in this thread Patch in this message | | | From | Fabian Frederick <> | Subject | [PATCH 1/1] drivers/gpu/drm/drm_buffer.c: remove unnecessary null test before kfree | Date | Sat, 28 Jun 2014 15:20:43 +0200 |
| |
This patch removes special case of last element and loops from idx to 0.
Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org Signed-off-by: Fabian Frederick <fabf@skynet.be> ---
This is untested.
drivers/gpu/drm/drm_buffer.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_buffer.c b/drivers/gpu/drm/drm_buffer.c index 0406110..86a4a4a 100644 --- a/drivers/gpu/drm/drm_buffer.c +++ b/drivers/gpu/drm/drm_buffer.c @@ -80,11 +80,7 @@ int drm_buffer_alloc(struct drm_buffer **buf, int size) error_out: - /* Only last element can be null pointer so check for it first. */ - if ((*buf)->data[idx]) - kfree((*buf)->data[idx]); - - for (--idx; idx >= 0; --idx) + for (; idx >= 0; --idx) kfree((*buf)->data[idx]); kfree(*buf); -- 1.8.4.5
| |