lkml.org 
[lkml]   [2014]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] cgroup: fix mount failure in a corner case
Hello, Li.

On Fri, Jun 27, 2014 at 05:13:12PM +0800, Li Zefan wrote:
> + for_each_subsys(ss, i) {
> + if (!(opts.subsys_mask & (1 << i)) ||
> + ss->root == &cgrp_dfl_root)
> + continue;
> +
> + if (!percpu_ref_tryget_live(&ss->root->cgrp.self.refcnt)) {
> + mutex_unlock(&cgroup_mutex);
> + msleep(10);
> + ret = restart_syscall();
> + goto out_free;
> + }

Why not just put it immediately? We know that it's not gonna be
destroyed while holding cgroup_mutex. It may look a bit weird but
this is a pretty special case anyway and deferring put doesn't buy
anything.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2014-06-28 14:41    [W:0.085 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site