Messages in this thread | | | Subject | Re: [PATCH] ntfs: Drop cast | From | Anton Altaparmakov <> | Date | Sun, 29 Jun 2014 01:30:37 +0100 |
| |
Hi,
Thanks for your patch. Your patch is obviously correct however I actually prefer to have the type casts in place because it clearly shows what the variable type being assigned to is so I find it makes the code more readable to cast void pointers to the target variable type so I don't have to go and look up the type higher up. Having said that I don't feel that strongly about it so I have no real objection to the patch getting applied...
Best regards,
Anton
On 28 Jun 2014, at 14:33, Himangi Saraogi <himangi774@gmail.com> wrote:
> This patch removes the cast on data of type void * as it is not needed. > The following Coccinelle semantic patch was used for making the change: > > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T *)x)->f > | > - (T *) > e > ) > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > fs/ntfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c > index f47af5e..b3c55fc 100644 > --- a/fs/ntfs/inode.c > +++ b/fs/ntfs/inode.c > @@ -1817,7 +1817,7 @@ int ntfs_read_inode_mount(struct inode *vi) > i = vol->mft_record_size; > if (i < sb->s_blocksize) > i = sb->s_blocksize; > - m = (MFT_RECORD*)ntfs_malloc_nofs(i); > + m = ntfs_malloc_nofs(i); > if (!m) { > ntfs_error(sb, "Failed to allocate buffer for $MFT record 0."); > goto err_out;
-- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
| |